commit 7106b268566787f74365ca0f9ec5941e5b5a2793
author Lawrence D'Anna <lawrence_danna@apple.com> Sat Oct 19 07:05:33 2019 +0000
committer Lawrence D'Anna <lawrence_danna@apple.com> Sat Oct 19 07:05:33 2019 +0000
tree cd15f4bc697fed117586469a64cb37693c95deca
parent c10037436a786d82c1de9d06c62fb677f2352cca

[LLDB] bugfix: command script add -f doesn't work for some callables

Summary:
When users define a debugger command from python, they provide a callable
object.   Because the signature of the function has been extended, LLDB
needs to inspect the number of parameters the callable can take.

The rule it was using to decide was weird, apparently not tested, and
giving wrong results for some kinds of python callables.

This patch replaces the weird rule with a simple one: if the callable can
take 5 arguments, it gets the 5 argument version of the signature.
Otherwise it gets the old 4 argument version.

It also adds tests with a bunch of different kinds of python callables
with both 4 and 5 arguments.

Reviewers: JDevlieghere, clayborg, labath, jingham

Reviewed By: labath

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D69014

git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@375333 91177308-0d34-0410-b5e6-96231b3b80d8