commit 04e0d2e8ddce6bc4309b559dd99c365bb27271b9
author Lawrence D'Anna <lawrence_danna@apple.com> Thu Oct 17 22:22:06 2019 +0000
committer Lawrence D'Anna <lawrence_danna@apple.com> Thu Oct 17 22:22:06 2019 +0000
tree d5acee35cee23c4a978ce0bdc6736c6095650162
parent 45131c3edaf75f2c1caa68486e08f7092312d28c

clean up the implementation of PythonCallable::GetNumArguments

Summary:
The current implementation of PythonCallable::GetNumArguments
is not exception safe, has weird semantics, and is just plain
incorrect for some kinds of functions.

Python 3.3 introduces inspect.signature, which lets us easily
query for function signatures in a sane and documented way.

This patch leaves the old implementation in place for < 3.3,
but uses inspect.signature for modern pythons.   It also leaves
the old weird semantics in place, but with FIXMEs grousing about
it.   We should update the callers and fix the semantics in a
subsequent patch.    It also adds some tests.

Reviewers: JDevlieghere, clayborg, labath, jingham

Reviewed By: labath

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D68995

git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@375181 91177308-0d34-0410-b5e6-96231b3b80d8