commit f3e334355b322af5b76940ae71242e8e69023710
author Nico Weber <nicolasweber@gmx.de> Tue Jul 23 19:00:01 2019 +0000
committer Nico Weber <nicolasweber@gmx.de> Tue Jul 23 19:00:01 2019 +0000
tree 8ab79ce150a5e9e1c48d474e18a74a15f5d68d34
parent 8e53ee7a6bc5ecf2e4b3a194a79f920dfa058fee

ld.lld: Demangle symbols from archives in diagnostics

This ports r366573 from COFF to ELF.

There are now to toString(Archive::Symbol), one doing MSVC demangling
in COFF and one doing Itanium demangling in ELF, so rename these two
to toCOFFString() and to toELFString() to not get a duplicate symbol.

Nothing ever passes a raw Archive::Symbol to CHECK(), so these not
being part of the normal toString() machinery seems ok.

There are two code paths in the ELF linker that emits this type of
diagnostic:

1. The "normal" one in InputFiles.cpp. This is covered by the tweaked test.

2. An additional one that's only used for libcalls if there's at least
   one bitcode in the link, and if the libcall symbol is lazy, and
   lazily loaded from an archive (i.e. not from a lazy .o file).
   (This code path was added in r339301.) Since all libcall names so far
   are C symbols and never mangled, the change there is not observable
   and hence not covered by tests.

Differential Revision: https://reviews.llvm.org/D65095

git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@366836 91177308-0d34-0410-b5e6-96231b3b80d8