commit d8dd02ff738d40a11226cc86aa92634bfe80572b
author Nico Weber <nicolasweber@gmx.de> Tue Aug 07 19:10:28 2018 +0000
committer Nico Weber <nicolasweber@gmx.de> Tue Aug 07 19:10:28 2018 +0000
tree 77b1bef796f63ffe61dbca6510e717ecea58c35c
parent 8588d9243680eaf1b9713ac34c6599d73471e843

lld-link: Take /SUBSYSTEM into account for automatic /ENTRY detection.

If /subsystem:windows is passed, link.exe only looks for WinMain and wWinMain,
and if /subsystem:console is passed it only looks for main and wmain. lld-link
used to look for all 4 in both cases. This patch makes lld-link match
link.exe's behavior.

This requires that the subsystem is known by the time findDefaultEntry() gets
called. findDefaultEntry() is called before the main link loop, so that the
loop can mark the entry point as undefined. That means inferSubsystem() has to
be called above the main loop as well. This in turn means /subsystem: from
.drectve sections only has an effect on entry point inference for obj files
passed to lld-link directly (and not in obj files found later in .lib files).
link.exe seems to ignore /subsystem: for obj files from lib files completely
(while in lld it's ignored only for entry point detection but it still
overrides /subsystem: flags passed on the command line for the value that gets
written in the output file).

Also, if the subsytem isn't needed (e.g. when only writing a /def: lib file and
not writing a coff file), link.exe doesn't complain if the subsystem isn't
known, so both subsystem and entry point handling should be below the early
return lld has for that case.

Fixes PR36523.
https://reviews.llvm.org/D50316


git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@339165 91177308-0d34-0410-b5e6-96231b3b80d8