commit b01e5d503bb0af6926b71da4b0aa6c25b123ad29
author Kostya Serebryany <kcc@google.com> Thu May 10 20:24:39 2018 +0000
committer Copybara-Service <copybara-worker@google.com> Thu Mar 25 23:16:57 2021 -0700
tree b4893088ae58028ab8230ab5327d7d42236e0b36
parent e01d11a01ab200e00a040af3140295e977b7f1df

[libFuzzer] remove the dump_coverage flag, it hasn't been working with the inline sanitizer coverage anyway

llvm-svn: 332036
GitOrigin-RevId: d80e821646a15eeb72395f13a321c6b5df79e015

FuzzerDriver.cpp

diff --git a/FuzzerDriver.cpp b/FuzzerDriver.cpp
index 3ee8c26..68f164f 100644
--- a/FuzzerDriver.cpp
+++ b/FuzzerDriver.cpp
@@ -615,7 +615,6 @@
   Options.PrintFinalStats = Flags.print_final_stats;
   Options.PrintCorpusStats = Flags.print_corpus_stats;
   Options.PrintCoverage = Flags.print_coverage;
-  Options.DumpCoverage = Flags.dump_coverage;
   Options.UseFeatureFrequency = Flags.use_feature_frequency;
   if (Flags.exit_on_src_pos)
     Options.ExitOnSrcPos = Flags.exit_on_src_pos;

FuzzerFlags.def

diff --git a/FuzzerFlags.def b/FuzzerFlags.def
index 5905d0d..1ba086f 100644
--- a/FuzzerFlags.def
+++ b/FuzzerFlags.def
@@ -107,9 +107,7 @@
   "If 1, print statistics on corpus elements at exit.")
 FUZZER_FLAG_INT(print_coverage, 0, "If 1, print coverage information as text"
                                    " at exit.")
-FUZZER_FLAG_INT(dump_coverage, 0, "Deprecated."
-                                  " If 1, dump coverage information as a"
-                                  " .sancov file at exit.")
+FUZZER_DEPRECATED_FLAG(dump_coverage)
 FUZZER_FLAG_INT(handle_segv, 1, "If 1, try to intercept SIGSEGV.")
 FUZZER_FLAG_INT(handle_bus, 1, "If 1, try to intercept SIGBUS.")
 FUZZER_FLAG_INT(handle_abrt, 1, "If 1, try to intercept SIGABRT.")

FuzzerLoop.cpp

diff --git a/FuzzerLoop.cpp b/FuzzerLoop.cpp
index 41acb5a..dfa6cf3 100644
--- a/FuzzerLoop.cpp
+++ b/FuzzerLoop.cpp
@@ -347,8 +347,6 @@
 void Fuzzer::PrintFinalStats() {
   if (Options.PrintCoverage)
     TPC.PrintCoverage();
-  if (Options.DumpCoverage)
-    TPC.DumpCoverage();
   if (Options.PrintCorpusStats)
     Corpus.PrintStats();
   if (!Options.PrintFinalStats)

FuzzerOptions.h

diff --git a/FuzzerOptions.h b/FuzzerOptions.h
index 6131cc1..4fd4e8d 100644
--- a/FuzzerOptions.h
+++ b/FuzzerOptions.h
@@ -52,7 +52,6 @@
   bool PrintFinalStats = false;
   bool PrintCorpusStats = false;
   bool PrintCoverage = false;
-  bool DumpCoverage = false;
   bool DetectLeaks = true;
   int PurgeAllocatorIntervalSec = 1;
   int UseFeatureFrequency = false;

FuzzerTracePC.cpp

diff --git a/FuzzerTracePC.cpp b/FuzzerTracePC.cpp
index f8c193e..4b106e5 100644
--- a/FuzzerTracePC.cpp
+++ b/FuzzerTracePC.cpp
@@ -269,15 +269,6 @@
   FunctionEndCallback("", "");
 }
 
-void TracePC::DumpCoverage() {
-  if (EF->__sanitizer_dump_coverage) {
-    Vector<uintptr_t> PCsCopy(GetNumPCs());
-    for (size_t i = 0; i < GetNumPCs(); i++)
-      PCsCopy[i] = PCs()[i] ? GetPreviousInstructionPc(PCs()[i]) : 0;
-    EF->__sanitizer_dump_coverage(PCsCopy.data(), PCsCopy.size());
-  }
-}
-
 // Value profile.
 // We keep track of various values that affect control flow.
 // These values are inserted into a bit-set-based hash map.

FuzzerTracePC.h

diff --git a/FuzzerTracePC.h b/FuzzerTracePC.h
index 0cf4e72..27ff47c 100644
--- a/FuzzerTracePC.h
+++ b/FuzzerTracePC.h
@@ -102,7 +102,6 @@
   void PrintModuleInfo();
 
   void PrintCoverage();
-  void DumpCoverage();
 
   void AddValueForMemcmp(void *caller_pc, const void *s1, const void *s2,
                          size_t n, bool StopAtZero);