commit 6033af7b886804e5c25b0048c8c611af986d63a7
author Matt Morehouse <mascasa@google.com> Wed May 02 02:55:28 2018 +0000
committer Copybara-Service <copybara-worker@google.com> Thu Mar 25 23:16:52 2021 -0700
tree 63114f65cc51f2fa48b8a4704f8c6d664b1ad57d
parent 53bf7e77691d482ef31e25acb88b52a0f007136d

[libFuzzer] Don't short-circuit from CrashCallback.

Short-circuiting causes tests to fail on Mac since libFuzzer crashes
rather than exiting with an error code when an unexpected signal
happens.

llvm-svn: 331324
GitOrigin-RevId: 7764a04af007eca68eafcf5caaea560ed05e35a9

FuzzerLoop.cpp

diff --git a/FuzzerLoop.cpp b/FuzzerLoop.cpp
index 7a26370..6cc220d 100644
--- a/FuzzerLoop.cpp
+++ b/FuzzerLoop.cpp
@@ -228,9 +228,8 @@
 }
 
 void Fuzzer::CrashCallback() {
-  if (EF->__sanitizer_acquire_crash_state &&
-      !EF->__sanitizer_acquire_crash_state())
-    return;
+  if (EF->__sanitizer_acquire_crash_state)
+    EF->__sanitizer_acquire_crash_state();
   Printf("==%lu== ERROR: libFuzzer: deadly signal\n", GetPid());
   if (EF->__sanitizer_print_stack_trace)
     EF->__sanitizer_print_stack_trace();