commit 5ef4cfd263309458afe27246d66f370e3b351faa
author Jean-Francois Simoneau <jfsimoneau@users.noreply.github.com> Mon Nov 20 22:14:00 2023 -0500
committer GitHub <noreply@github.com> Mon Nov 20 22:14:00 2023 -0500
tree 9b788d20837fca4ec3febbcacbd621c814550bac
parent 03fecb2f784d05dbdd8d14930b9b237016e44770

Fix bugprone warnings (#1721)

httplib.h

diff --git a/httplib.h b/httplib.h
index 39c5fe5..30b4fbc 100644
--- a/httplib.h
+++ b/httplib.h
@@ -2227,7 +2227,7 @@
 
 inline size_t to_utf8(int code, char *buff) {
   if (code < 0x0080) {
-    buff[0] = (code & 0x7F);
+    buff[0] = static_cast<char>(code & 0x7F);
     return 1;
   } else if (code < 0x0800) {
     buff[0] = static_cast<char>(0xC0 | ((code >> 6) & 0x1F));
@@ -2835,7 +2835,7 @@
   size_t read_buff_off_ = 0;
   size_t read_buff_content_size_ = 0;
 
-  static const size_t read_buff_size_ = 1024 * 4;
+  static const size_t read_buff_size_ = 1024l * 4;
 };
 
 #ifdef CPPHTTPLIB_OPENSSL_SUPPORT
@@ -3804,7 +3804,7 @@
 
     if (!line_reader.getline()) { return false; }
 
-    if (strcmp(line_reader.ptr(), "\r\n")) { return false; }
+    if (strcmp(line_reader.ptr(), "\r\n") != 0) { return false; }
 
     if (!line_reader.getline()) { return false; }
   }
@@ -3814,7 +3814,7 @@
   // Trailer
   if (!line_reader.getline()) { return false; }
 
-  while (strcmp(line_reader.ptr(), "\r\n")) {
+  while (strcmp(line_reader.ptr(), "\r\n") != 0) {
     if (line_reader.size() > CPPHTTPLIB_HEADER_MAX_LENGTH) { return false; }
 
     // Exclude line terminator