commit fdb3fe517659f6e21c2cca456ff5099e1bf0b4bf
author Leonard Chan <leonardchan@google.com> Fri Feb 26 11:13:42 2021 -0800
committer Copybara-Service <copybara-worker@google.com> Thu Mar 25 16:01:58 2021 -0700
tree 466af37ccd2cf795caeff5cdad60f473db4e4455
parent e70e3afa2b314125096caf5e85b5a4eaf51b4289

[scudo][test] Disable -Wfree-nonheap-object

As of 4f395db86b5cc11bb56853323d3cb1d4b6db5a0b which contains updates to
-Wfree-nonheap-object, a line in this test will trigger the warning. This
particular line is ok though since it's meant to test a free on a bad pointer.

Differential Revision: https://reviews.llvm.org/D97516

GitOrigin-RevId: bed888242662c2327b32b91a03635e079ad5667e

tests/wrappers_c_test.cpp

diff --git a/tests/wrappers_c_test.cpp b/tests/wrappers_c_test.cpp
index e01ac38..e8872a1 100644
--- a/tests/wrappers_c_test.cpp
+++ b/tests/wrappers_c_test.cpp
@@ -42,8 +42,19 @@
   EXPECT_NE(P, nullptr);
   EXPECT_LE(Size, malloc_usable_size(P));
   EXPECT_EQ(reinterpret_cast<uintptr_t>(P) % FIRST_32_SECOND_64(8U, 16U), 0U);
+
+  // An update to this warning in Clang now triggers in this line, but it's ok
+  // because the check is expecting a bad pointer and should fail.
+#if defined(__has_warning) && __has_warning("-Wfree-nonheap-object")
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wfree-nonheap-object"
+#endif
   EXPECT_DEATH(
       free(reinterpret_cast<void *>(reinterpret_cast<uintptr_t>(P) | 1U)), "");
+#if defined(__has_warning) && __has_warning("-Wfree-nonheap-object")
+#pragma GCC diagnostic pop
+#endif
+
   free(P);
   EXPECT_DEATH(free(P), "");