Google Git
Sign in
llvm / scudo / 7342450f80831381fb447a70f49c1f6ddf843932
commit7342450f80831381fb447a70f49c1f6ddf843932[log] [tgz]
authorChristopher Ferris <cferris1000@users.noreply.github.com>Tue Mar 26 14:47:48 2024 -0700
committerCopybara-Service <copybara-worker@google.com>Tue Mar 26 14:54:25 2024 -0700
tree1bfb574f4b4e4088e39abdca837ea8a349a7b043
parent88c3edfacd3b7c63d602bf63dbca0e5db7dba8fb [diff]
[scudo] Clean up string handling (#86364)

Do not abort if a vector cannot increase its own capacity. In that case,
push_back calls silently fail.

Modify the ScopedString implementation so that it no longer requires two
passes to do the format. Move the helper functions to be private member
functions so that they can use push_back directly. This allows the
capacity to be increased under the hood and/or silently discards data if
the capacity is exceeded and cannot be increased.

Add new tests for the Vector and ScopedString for capacity increase
failures.

Doing this so that if a map call fails, and we are attempting to write
an error string, we can still get some of the message dumped. This also
avoids crashing in Scudo code, and makes the caller handle any failures.

GitOrigin-RevId: 1949f7d6c9bd59172c01c7933e1c558797c47eac
8 files changed
tree: 1bfb574f4b4e4088e39abdca837ea8a349a7b043
  1. benchmarks/
  2. fuzz/
  3. include/
  4. tests/
  5. tools/
  6. allocator_common.h
  7. allocator_config.def
  8. allocator_config.h
  9. allocator_config_wrapper.h
  10. atomic_helpers.h
  11. bytemap.h
  12. checksum.cpp
  13. checksum.h
  14. chunk.h
  15. combined.h
  16. common.cpp
  17. common.h
  18. condition_variable.h
  19. condition_variable_base.h
  20. condition_variable_linux.cpp
  21. condition_variable_linux.h
  22. crc32_hw.cpp
  23. flags.cpp
  24. flags.h
  25. flags.inc
  26. flags_parser.cpp
  27. flags_parser.h
  28. fuchsia.cpp
  29. fuchsia.h
  30. internal_defs.h
  31. LICENSE.TXT
  32. linux.cpp
  33. linux.h
  34. list.h
  35. local_cache.h
  36. mem_map.cpp
  37. mem_map.h
  38. mem_map_base.h
  39. mem_map_fuchsia.cpp
  40. mem_map_fuchsia.h
  41. mem_map_linux.cpp
  42. mem_map_linux.h
  43. memtag.h
  44. mutex.h
  45. options.h
  46. platform.h
  47. primary32.h
  48. primary64.h
  49. quarantine.h
  50. release.cpp
  51. release.h
  52. report.cpp
  53. report.h
  54. report_linux.cpp
  55. report_linux.h
  56. secondary.h
  57. size_class_map.h
  58. stack_depot.h
  59. stats.h
  60. string_utils.cpp
  61. string_utils.h
  62. thread_annotations.h
  63. timing.cpp
  64. timing.h
  65. trusty.cpp
  66. trusty.h
  67. tsd.h
  68. tsd_exclusive.h
  69. tsd_shared.h
  70. vector.h
  71. wrappers_c.cpp
  72. wrappers_c.h
  73. wrappers_c.inc
  74. wrappers_c_bionic.cpp
  75. wrappers_c_checks.h
  76. wrappers_cpp.cpp