commit 207e887e9e791e5861c9830f567120e62747a3ac
author Hans Wennborg <hans@chromium.org> Tue Jul 28 12:26:37 2020 +0200
committer Copybara-Service <copybara-worker@google.com> Thu Aug 27 23:59:18 2020 -0700
tree edf7746de995e907d4a2919ef07cfa0e6f772b16
parent 63fb416462853047b09563b5f883acb123001b0b

Avoid use of std::make_unique in compiler-rt/lib/scudo/standalone/tests/combined_test.cpp

make_unique is a C++14 feature, and this prevents us from building on
Ubuntu Trusty. While we do use a C++14 compatible toolchain for building
in general, we fall back to the system toolchain for building the
compiler-rt tests.

The reason is that those tests get cross-compiled for e.g. 32-bit and
64-bit x86, and while the toolchain provides libstdc++ in those
flavours, the resulting compiler-rt test binaries don't get RPATH set
and so won't start if they're linked with that toolchain.

We've tried linking the test binaries against libstdc++ statically, by
passing COMPILER_RT_TEST_COMPILER_CFLAGS=-static-libstdc++. That mostly
works, but some test targets append -lstdc++ to the compiler invocation.

So, after spending way too much time on this, let's just avoid C++14
here for now.

GitOrigin-RevId: 7e8d5a90f2c101388d3b0bbce8555e871c670232