[HIP] Sync catch/include/ headers from upstream (#529)
* [HIP] Sync catch/include/ headers from upstream
Bring all shared catch test headers from rocm-systems
(projects/hip-tests/catch/include/) up to develop at 2dbdf82d08a.
New headers (18):
contract_cleanup.hh, cpu_grid.h, hip_test_checkers.hh,
hip_test_defgroups.hh, hip_test_helper.hh, hip_test_kernels.hh,
hip_test_process.hh, hip_test_rtc.hh, hip_test_smi.hh,
hip_test_temp_path.hh, hip_texture_helper.hh, kernel_mapping.hh,
kernels.hh, memcpy1d_tests_common.hh, memcpy3d_tests_common.hh,
performance_common.hh, threaded_zig_zag_test.hh, warp_common.hh
Updated headers (5):
hip_test_common.hh, hip_test_context.hh, hip_test_level.hh,
resource_guards.hh, utils.hh
Skipped: cmd_options.hh — the upstream version removes struct members
(iterations, warmups, etc.) that llvm-test-suite's main.cc still uses.
That header will be updated when main.cc is synced separately.
These headers are shared by 27+ upstream test directories and are
prerequisites for porting additional catch test categories (deviceLib,
warp, rtc, atomics, etc.).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* [HIP] Address review: drop unused headers, complete framework sync to 2dbdf82d08a
Per review feedback on #529:
- Remove 18 new headers that no ported test category uses yet. Eight
are only consumed by runtime directories we do not plan to port;
the rest are better added by the port that first needs them.
- Sync cmd_options.hh, main.cc, and hip_test_features.cc to upstream
rocm-systems at 2dbdf82d08a, completing the framework sync so that
every file under catch/include/ and catch/hipTestMain/ is now
byte-identical to that commit.
cmd_options.hh: remove members upstream dropped (iterations,
warmups, cg_iterations, cg/warp_reduction_factor,
accuracy_iterations, accuracy_max_memory, max_memory,
reduction_factor).
main.cc: adopt upstream's simplified flow (session.run(argc,argv),
g_hipStrictLastErrorFailed check), removing the CLI options that
bound to dropped CmdOptions members and the ENABLE_YAML_TAGS
level-filtering path that upstream itself removed between
41c9e94cff and 2dbdf82d08a.
hip_test_features.cc: add gfx11-7-generic target entries
(gfx1170, gfx1171).
Tested: check-hip-catch (compiler, device_memory, math) on MI210
(gfx90a) / ROCm 7.2.0. 559/568 pass; 9 pre-existing math accuracy
failures unchanged from before this patch.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
8 files changed