commit | 9d5c2fd2ff6e77635efbf2c168d3ce99555b17d7 | [log] [tgz] |
---|---|---|
author | Logan Smith <logan.r.smith0@gmail.com> | Wed Jul 22 14:16:35 2020 -0700 |
committer | Copybara-Service <copybara-worker@google.com> | Thu Sep 03 18:11:20 2020 -0700 |
tree | f05253f574ed238feaa45a5c86b9a0315eaa4549 | |
parent | cb2e17422517e207f3a00c56e075aa19d7ed567e [diff] |
Try enabling -Wsuggest-override again, using add_compile_options instead of add_compile_definitions for disabling it in unittests/ directories. Using add_compile_definitions caused the flag to be passed to rc.exe on Windows and thus broke Windows builds. GitOrigin-RevId: 388c9fb1af48b059d8b65cb2e002e0992d147aa5