commit a16450a90bcb723c3406a1319f86cf902b0cfc41
author Jason Henline <jhen@google.com> Mon Dec 19 21:34:07 2016 +0000
committer Copybara-Service <copybara-worker@google.com> Tue Sep 01 01:05:36 2020 -0700
tree 104afd46ba2f604be7ab1bb73c92065d37f34635
parent 8fbecbbe93ba62217b45c7fa4821275075327077

[Axccel] Remove -Wno-missing-braces in build

Summary:
I originally added the -Wno-missing-braces flag because I thought it was
erroneously flagging std::array initializations. Now I realize the extra
braces really are desired for these initializations, so I'm turning the
warning flag back on.

Reviewers: jlebar

Subscribers: mgorny, parallel_libs-commits

Differential Revision: https://reviews.llvm.org/D27941

llvm-svn: 290137
GitOrigin-RevId: 492c5a16741e40a869b1b9981261c7644fd0f1c9

acxxel/CMakeLists.txt

diff --git a/acxxel/CMakeLists.txt b/acxxel/CMakeLists.txt
index 4b21da3..547dd62 100644
--- a/acxxel/CMakeLists.txt
+++ b/acxxel/CMakeLists.txt
@@ -35,7 +35,7 @@
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
 
 # Add warning flags.
-set(CMAKE_CXX_FLAGS  "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wno-missing-braces")
+set(CMAKE_CXX_FLAGS  "${CMAKE_CXX_FLAGS} -Wall -Wextra")
 
 add_library(
     acxxel

acxxel/examples/opencl_example.cpp

diff --git a/acxxel/examples/opencl_example.cpp b/acxxel/examples/opencl_example.cpp
index 713daac..4e3cf07 100644
--- a/acxxel/examples/opencl_example.cpp
+++ b/acxxel/examples/opencl_example.cpp
@@ -57,9 +57,9 @@
 
 int main() {
   float A = 2.f;
-  std::array<float, 3> X = {0.f, 1.f, 2.f};
-  std::array<float, 3> Y = {3.f, 4.f, 5.f};
-  std::array<float, 3> Expected = {3.f, 6.f, 9.f};
+  std::array<float, 3> X{{0.f, 1.f, 2.f}};
+  std::array<float, 3> Y{{3.f, 4.f, 5.f}};
+  std::array<float, 3> Expected{{3.f, 6.f, 9.f}};
   saxpy(A, X, Y);
   for (int I = 0; I < 3; ++I)
     if (X[I] != Expected[I]) {

acxxel/tests/span_test.cpp

diff --git a/acxxel/tests/span_test.cpp b/acxxel/tests/span_test.cpp
index eee5aef..a425ceb 100644
--- a/acxxel/tests/span_test.cpp
+++ b/acxxel/tests/span_test.cpp
@@ -79,12 +79,12 @@
 }
 
 TEST(Span, StdArrayConstruction) {
-  std::array<int, 3> Array{0, 1, 2};
+  std::array<int, 3> Array{{0, 1, 2}};
   acxxel::Span<int> Span(Array);
   EXPECT_EQ(Span.data(), Array.data());
   EXPECT_EQ(static_cast<size_t>(Span.size()), Array.size());
 
-  std::array<const int, 3> ConstArray{0, 1, 2};
+  std::array<const int, 3> ConstArray{{0, 1, 2}};
   acxxel::Span<const int> ConstSpan(ConstArray);
   EXPECT_EQ(ConstSpan.data(), ConstArray.data());
   EXPECT_EQ(static_cast<size_t>(ConstSpan.size()), ConstArray.size());