commit dd1aab2954d3ecde32c44f2363ddc871c6b9a093
author Alex Zinenko <zinenko@google.com> Mon Nov 22 13:19:36 2021 +0100
committer Copybara-Service <copybara-worker@google.com> Mon Nov 22 09:24:06 2021 -0800
tree 9f97b73c4bbb862493f107fcf3b6ae5b684d94ec
parent 9242b4ed45bb120416b94ca0d43e419d3b769c35

[mlir] support recursive types in type conversion infra

MLIR supports recursive types but they could not be handled by the conversion
infrastructure directly as it would result in infinite recursion in
`convertType` for elemental types. Support this case by keeping the "call
stack" of nested type conversions in the TypeConverter class and by passing it
as an optional argument to the individual conversion callback. The callback can
then check if a specific type is present on the stack more than once to detect
and handle the recursive case.

This approach is preferred to the alternative approach of having a separate
callback dedicated to handling only the recursive case as the latter was
observed to introduce ~3% time overhead on a 50MB IR file even if it did not
contain recursive types.

This approach is also preferred to keeping a local stack in type converters
that need to handle recursive types as that would compose poorly in case of
out-of-tree or cross-project extensions.

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D113579

GitOrigin-RevId: 9c5982ef8e95a0b5acdbd0d2599fbd87526abe2e