commit e1e96fcfe90b668fec5b8b3e8c2ad87b839f7ce6
author Matthias Springer <me@m-sp.org> Fri Sep 12 14:32:42 2025 +0100
committer Copybara-Service <copybara-worker@google.com> Fri Sep 12 06:35:19 2025 -0700
tree d0e75e0c1e5b8d0455d63eb1c1755111cba8033d
parent d3c5b241b5a30d3471dc2c851185217915026c19

[mlir][Transforms] Fix crash in `reconcile-unrealized-casts` (#158067)

The `reconcile-unrealized-casts` pass used to crash when the input
contains circular chains of `unrealized_conversion_cast` ops.

Furthermore, the `reconcileUnrealizedCasts` helper functions used to
erase ops that were not passed via the `castOps` operand. Such ops are
now preserved. That's why some integration tests had to be changed.

Also avoid copying the set of all unresolved materializations in
`convertOperations`.

This commit is in preparation of turning `RewriterBase::replaceOp` into
a non-virtual function.

---------

Co-authored-by: Mehdi Amini <joker.eph@gmail.com>
GitOrigin-RevId: 03e3ce82b926a4c138e6e0bacfcd1d5572c3e380