commit | 03cb7e9b7c17f1ec279861d529e4fbbc3efdad6b | [log] [tgz] |
---|---|---|
author | seongwon bang <makesource@gmail.com> | Thu Nov 25 21:23:48 2021 +0900 |
committer | Copybara-Service <copybara-worker@google.com> | Thu Nov 25 04:26:10 2021 -0800 |
tree | 8b19cf8a66b0ec74af68980a442e2e3370bd16e4 | |
parent | 6ce4e68030c56d694eaf818a44e983eb22468b39 [diff] |
[MLIR] [docs] Fix misguided examples in memref.subview operation. The examples in `memref.subview` operation are misguided in that subview's strides operands mean "memref-rank number of strides that compose multiplicatively with the base memref strides in each dimension.". So the below examples should be changed from `Strides: [64, 4, 1]` to `Strides: [1, 1, 1]` Before changes ``` // Subview with constant offsets, sizes and strides. %1 = memref.subview %0[0, 2, 0][4, 4, 4][64, 4, 1] : memref<8x16x4xf32, (d0, d1, d2) -> (d0 * 64 + d1 * 4 + d2)> to memref<4x4x4xf32, (d0, d1, d2) -> (d0 * 64 + d1 * 4 + d2 + 8)> ``` After changes ``` // Subview with constant offsets, sizes and strides. %1 = memref.subview %0[0, 2, 0][4, 4, 4][1, 1, 1] : memref<8x16x4xf32, (d0, d1, d2) -> (d0 * 64 + d1 * 4 + d2)> to memref<4x4x4xf32, (d0, d1, d2) -> (d0 * 64 + d1 * 4 + d2 + 8)> ``` Also I fixed some syntax issues in docs related with memref layout map and added detailed explanation in subview rank reducing case. Reviewed By: herhut Differential Revision: https://reviews.llvm.org/D114500 GitOrigin-RevId: 35c1e6ac1af0f3c61c756cb30a2c99d8775da4c6
See https://mlir.llvm.org/ for more information.