tree 68df6c46fa0722db4110aa6c6ba88d540fba94f8
parent d5144f6e3b5c1303bfe1f711b64f286d75ccbee0
author Arthur Eubanks <aeubanks@google.com> 1659462210 -0700
committer Copybara-Service <copybara-worker@google.com> 1659572821 -0700

[BoundsChecking] Fix merging of sizes

BoundsChecking uses ObjectSizeOffsetEvaluator to keep track of the
underlying size/offset of pointers in allocations.  However,
ObjectSizeOffsetVisitor (something ObjectSizeOffsetEvaluator
uses to check for constant sizes/offsets)
doesn't quite treat sizes and offsets the same way as
BoundsChecking.  BoundsChecking wants to know the size of the
underlying allocation and the current pointer's offset within
it, but ObjectSizeOffsetVisitor only cares about the size
from the pointer to the end of the underlying allocation.

This only comes up when merging two size/offset pairs. Add a new mode to
ObjectSizeOffsetVisitor which cares about the underlying size/offset
rather than the size from the current pointer to the end of the
allocation.

Fixes a false positive with -fsanitize=bounds.

Reviewed By: vitalybuka, asbirlea

Differential Revision: https://reviews.llvm.org/D131001

GitOrigin-RevId: 203296d642c385da07a62098050b08493ed8b236