tree 4eaa8810215621d3e0d6a85099621b2608dae363
parent 2db8edd4b6970134c19b56d642c033b375168853
author Sanjay Patel <spatel@rotateright.com> 1638111577 -0500
committer Copybara-Service <copybara-worker@google.com> 1638112241 -0800

[InstCombine] use decomposeBitTestICmp to make icmp (trunc X), C more consistent

This is a follow-on suggested in D112634.
Two folds that were added with that patch are subsumed in the call to
decomposeBitTestICmp, and two other folds are potentially inverted.

The deleted folds were very specialized by instcombine standards
because they were restricted to legal integer types based on the data
layout. This generalizes the canonical form independent of target/types.

This change has a reasonable chance of exposing regressions either in
IR or codegen, but I don't have any evidence for either of those yet.
A spot check of asm across several in-tree targets shows variations
that I expect are mostly neutral.

We have one improvement in an existing IR test that I noted with a
comment. Using mask ops might also make more code match with D114272.

Differential Revision: https://reviews.llvm.org/D114386

GitOrigin-RevId: f55d1eb3746a17688ca10d4e699ccea7d0f15378