tree 54da5fbfe3f87ee4fdabbebbbefe29d699e06697
parent bef45fb57367696a994768d24d8c5b5169d4cfd6
author Peter Collingbourne <peter@pcc.me.uk> 1418760295 +0000
committer Copybara-Service <copybara-worker@google.com> 1599161510 -0700

Use the object's package to mangle method names, rather than the receiver's package

If we use the receiver's package, we can end up with identical manglings
for different functions. Consider:

package p
type U struct{}
func (U) f()

package q
import "p"
type T struct { p.U }
func (T) f()

The method set of *T has two synthetic methods named (*T).f(); one forwards to
(T).f(), and the other to (U).f(). Previously, we were distinguishing them
by the receiver's package, and in this case because both methods have the
same receiver, they received the same name.

The methods are correctly distinguished by the package owning the identifier
"f", which is available via f.Object().Pkg().

Differential Revision: http://reviews.llvm.org/D6673

llvm-svn: 224357
GitOrigin-RevId: 545e7276a870c60d4d289b72b38e1529dae2acd7