tree 65c21e9fb9da05bb0c91cb45f7129e8499a23fa3
parent 184c1bd59ef3b24117f4e00147fe380345da667f
author Jason Molenda <jason@molenda.com> 1618614616 -0700
committer Copybara-Service <copybara-worker@google.com> 1618719958 -0700

Target::ReadMemory read from read-only binary file Section, not memory

Commiting this patch for Augusto Noronha who is getting set
up still.

This patch changes Target::ReadMemory so the default behavior
when a read is in a Section that is read-only is to fetch the
data from the local binary image, instead of reading it from
memory.  Update all callers to use their old preferences
(the old prefer_file_cache bool) using the new API; we should
revisit these calls and see if they really intend to read
live memory, or if reading from a read-only Section would be
equivalent and important for performance-sensitive cases.

rdar://30634422

Differential revision: https://reviews.llvm.org/D100338

GitOrigin-RevId: e9fe788d326090cb6155c0dec90b44c932273dd3