| commit | 3fe4e6a705f910f95402a9e209f0267f82be9e05 | [log] [tgz] |
|---|---|---|
| author | Sad Al Abdullah <siam9090@gmail.com> | Tue Jan 07 12:59:09 2025 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Jan 07 13:00:29 2025 -0800 |
| tree | 97d8b8fd4e15d05ebed9df69b996c93c3220f593 | |
| parent | b193bbdec7a731fe422424cdea0e178bfee90adb [diff] |
Fixing FindUnusedPort method tcp_socket object creation with proper constructor parameter (#121879) ### Issue: Currently lldb `platform connect unix-connect://localhost:43045/` is failing and showing "Failed to connect port" error message.  ### Cause: TCPSocket(bool should_close, bool child_processes_inherit) constructor was removed in commit [c1dff71](https://github.com/llvm/llvm-project/commit/c1dff7152592f1beee9059ee8e2cb3cc68baea4d#diff-91817651b505a466ea94ddc44eca856f62073e03b05d0d0d2f4a55dcfea0002eL20). However, the tcp_socket object creation still passes the deleted constructor parameters, which causes the invocation of the wrong constructor. As a result, the `FindUnusedPort` method is unable to resolve the local port and always returns 0. GitOrigin-RevId: 56936ec63dcc03f64c129ee45716431e56e5d3d1