tree dd80603e9d6150def4591c89303275bbc145c609
parent 57082bc3f6e9bf9e7d11656b78c69fe8be930633
author Greg McGary <gkm@fb.com> 1615349729 -0800
committer Copybara-Service <copybara-worker@google.com> 1616052854 -0700

[lld-macho][NFC] when reasonable, replace auto keyword with type names

lld policy discourages `auto`. Replace it with a type name whenever reasonable. Retain `auto` to avoid ...
* redundancy, as for decls such as `auto *t = mumble_cast<TYPE *>` or similar that specifies the result type on the RHS
* verbosity, as for iterators
* gratuitous suffering, as for lambdas

Along the way, add `const` when appropriate.

Note: a future diff will ...
* add more `const` qualifiers
* remove `opt::` when we are already `using llvm::opt`

Differential Revision: https://reviews.llvm.org/D98313

GitOrigin-RevId: fdc0c21973c80b56381888c84125bdec7c1c1fbe