)]}'
{
  "commit": "f62e5088211ddcb42e87ad9593df1808fb39da57",
  "tree": "99bf22652c27e7aaca492c0fde5791956582fa92",
  "parents": [
    "bf86c4261a0eafd4bc263c7f9a98f08b8c1fdd05"
  ],
  "author": {
    "name": "Louis Dionne",
    "email": "ldionne.2@gmail.com",
    "time": "Wed Jul 14 11:36:22 2021 -0400"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Thu Jul 15 15:07:46 2021 -0700"
  },
  "message": "[runtimes] Serialize all Lit params instead of passing them to add_lit_testsuite\n\nadd_lit_testsuite() takes Lit parameters passed to it and adds them\nto the parameters used globally when running all test suites. That\nmeans that a target like `check-all`, which ends up calling Lit on\nthe whole monorepo, will see the test parameters for all the individual\nproject\u0027s test suites.\n\nSo, for example, it would see `--param std\u003dc++03` (from libc++abi), and\n`--param std\u003dc++03` (from libc++), and `--param whatever` (from another\nproject being tested at the same time). While always unclean, that works\nwhen the parameters all agree. However, if the parameters share the same\nname but have different values, only one of those two values will be used\nand it will be incredibly confusing to understand why one of the test\nsuites is being run with the incorrect parameter value.\n\nFor that reason, this commit moves away from using add_lit_testsuite()\u0027s\nPARAM functionality, and serializes the parameter values for the runtimes\nin the generated config.py file instead, which is local to the specific\ntest suite.\n\nDifferential Revision: https://reviews.llvm.org/D105991\n\nGitOrigin-RevId: 0c3401c86e82cb5d8ba0c9dec6573473e505c5fc\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "5be44e566b6c08ce86c32068a7ccb9d71327c61d",
      "old_mode": 33188,
      "old_path": "test/CMakeLists.txt",
      "new_id": "8e7fa442710451b3a3f8d2411d131574c1c4b3a0",
      "new_mode": 33188,
      "new_path": "test/CMakeLists.txt"
    }
  ]
}