tree 1f1dd35abe88f46135cd8f50ed2ccb0117a6b4a1
parent 74ee8fcd2156faa4f02ebabf9b9fb6d9b04fe377
author Louis Dionne <ldionne@apple.com> 1593187739 -0400
committer Copybara-Service <copybara-worker@google.com> 1618252331 -0700

[libc++] Include <__config_site> from <__config>

Prior to this patch, we would generate a fancy <__config> header by
concatenating <__config_site> and <__config>. This complexifies the
build system and also increases the difference between what's tested
and what's actually installed.

This patch removes that complexity and instead simply installs <__config_site>
alongside the libc++ headers. <__config_site> is then included by <__config>,
which is much simpler. Doing this also opens the door to having different
<__config_site> headers depending on the target, which was impossible before.

It does change the workflow for testing header-only changes to libc++.
Previously, we would run `lit` against the headers in libcxx/include.
After this patch, we run it against a fake installation root of the
headers (containing a proper <__config_site> header). This makes use
closer to testing what we actually install, which is good, however it
does mean that we have to update that root before testing header changes.
Thus, we now need to run `ninja check-cxx-deps` before running `lit` by
hand.

Differential Revision: https://reviews.llvm.org/D97572

GitOrigin-RevId: c06a8f9caa51c7ea71dac716e0a35f5e343e4546