tree bad82f94173537241b0d04a8f24240b2626207fe
parent 74c00c654b1bb38b849ffedf74cbe728f293c27a
author Logan Smith <logan.r.smith0@gmail.com> 1595264771 -0700
committer Copybara-Service <copybara-worker@google.com> 1598602050 -0700

Enable -Wsuggest-override in the LLVM build

This patch adds Clang's new (and GCC's old) -Wsuggest-override to the warning flags for the LLVM build. The warning is a stronger form of -Winconsistent-missing-override which warns _everywhere_ that override is missing, not just in places where it's inconsistent within a class.

Some directories in the monorepo need the warning disabled for compatibility's, or sanity's, sake; in particular, libcxx/libcxxabi, and any code implementing or interoperating with googletest, googlemock, or google benchmark (which do not themselves use override). This patch adds -Wno-suggest-override to the relevant CMakeLists.txt's to accomplish this.

Differential Revision: https://reviews.llvm.org/D84126

GitOrigin-RevId: 8b16e45f66e24e4c10e2cea1b70d2b85a7ce64d5