| commit | 374a840992c2df8a6fca8c755891367062749d78 | [log] [tgz] |
|---|---|---|
| author | Logan Smith <logan.r.smith0@gmail.com> | Wed Jul 22 14:16:35 2020 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Fri Aug 28 01:07:37 2020 -0700 |
| tree | 9e8c5311a5b7026fc4b14561a318b44894b043f6 | |
| parent | ae7762e47d51b4f7633e39461a5459e60570cf11 [diff] |
Try enabling -Wsuggest-override again, using add_compile_options instead of add_compile_definitions for disabling it in unittests/ directories. Using add_compile_definitions caused the flag to be passed to rc.exe on Windows and thus broke Windows builds. GitOrigin-RevId: 388c9fb1af48b059d8b65cb2e002e0992d147aa5