| commit | a2aa0c60705b786a8b2d01a9bd9ab9952e67227b | [log] [tgz] |
|---|---|---|
| author | Petr Hosek <phosek@google.com> | Mon Jan 27 22:26:15 2025 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Mon Jan 27 22:31:22 2025 -0800 |
| tree | 09b8d718a5a52b660bc790c41659237a9c2ceff3 | |
| parent | 5c546282ff5da5be77a1b7371bc1da1483bf96ba [diff] |
Revert "[libcxx] Use alias for detecting overriden function" (#124431) Reverts llvm/llvm-project#120805 This change while desirable has two issues we discovered: - It is incompatible with `-funique-internal-linkage-names`, see https://github.com/llvm/llvm-project/pull/120805#discussion_r1913709817 - It is incompatible with `-fvisibility-global-new-delete=force-hidden`, see https://github.com/llvm/llvm-project/issues/123224#issuecomment-2607963878 We were hoping to address both of these issues with https://github.com/llvm/llvm-project/pull/122983, but that change has other issues we haven't yet managed to resolve. For now, we have decided to revert the change to avoid shipping a broken feature in LLVM 20, and we plan to follow up with a new approach post branch. GitOrigin-RevId: 4167ea2cb082a2acb00b8b1dc09aa780dc0e3110