tree a9752246932d38dabf542f0f39b8862a2f31a01b
parent ed63ea72bff2f8f6ea99747cbfc34a1da3ad17ac
author Mikhail Maltsev <mikhail.maltsev@arm.com> 1636981716 +0000
committer Copybara-Service <copybara-worker@google.com> 1636981855 -0800

[libcxx] Fix enable_if condition of std::reverse_iterator::operator=

The template std::is_assignable<T, U> checks that T is assignable from
U. Hence, the order of operands in the instantiation of
std::is_assignable in the std::reverse_iterator::operator= condition
should be reversed.

This issue remained unnoticed because std::reverse_iterator has an
implicit conversion constructor. This patch adds a test to check that
the assignment operator is used directly, without any implicit
conversions. The patch also adds a similar test for
std::move_iterator.

Reviewed By: Quuxplusone, ldionne, #libc

Differential Revision: https://reviews.llvm.org/D113417

GitOrigin-RevId: 6938270fa68d2242999802fdc306dc60326df020