tree 29e25e30f11b8fff6da4ff94508261f90fe622b3
parent 99c075a6fb59fac5b5714a3dac9091b661f5988c
author Muiez Ahmed <muiez@ibm.com> 1637268585 -0500
committer Copybara-Service <copybara-worker@google.com> 1637268954 -0800

[libc++] Resolve missing table_size symbol

The aim of this patch is to resolve the missing `table_size` symbol (see reduced test case). That const variable is declared and defined in //libcxx/include/locale//; however, the test case suggests that the symbol is missing. This is due to a C++ pitfall (highlighted [[ https://quuxplusone.github.io/blog/2020/09/19/value-or-pitfall/ | here ]]). In summary, assigning the reference of `table_size` doesn't enforce the const-ness and expects to find `table_size` in the DLL. The fix is to use `constexpr` or have an out-of-line definition in the src (for consistency).

Differential Revision: https://reviews.llvm.org/D110647

GitOrigin-RevId: 049f6c29a6f0a91263588d470c1b09dccd4c70d4