[libc][benchmarks] Link the memory benchmark exes to functions from LLVM libc.
Summary:
To get the target order correct, the benchmarks directory has been moved
one level higher. Previously, it was living in the utils directory. The
utils directory is a collection of utils which are to be used by the
tests and implementations. However, benchmarks *use* the
implementations. So, moving it out of utils helps us setup proper
target level dependencies.
Reviewers: gchatelet
Differential Revision: https://reviews.llvm.org/D81910
GitOrigin-RevId: 438f7fc068f9ba5555052c4af0b10f5e816c3a01
diff --git a/CMakeLists.txt b/CMakeLists.txt
index b774eac..58613fd 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -99,3 +99,5 @@
add_subdirectory(test)
add_subdirectory(fuzzing)
endif()
+
+add_subdirectory(benchmarks)
diff --git a/utils/benchmarks/CMakeLists.txt b/benchmarks/CMakeLists.txt
similarity index 94%
rename from utils/benchmarks/CMakeLists.txt
rename to benchmarks/CMakeLists.txt
index 24741e0..6f3cfdb 100644
--- a/utils/benchmarks/CMakeLists.txt
+++ b/benchmarks/CMakeLists.txt
@@ -174,7 +174,7 @@
add_libc_benchmark_analysis(${conf_target} ${run_target})
endfunction()
-function(add_libc_benchmark name file)
+function(add_libc_benchmark name file entrypoint_target)
set(libc_target libc-${name}-benchmark)
add_executable(${libc_target}
EXCLUDE_FROM_ALL
@@ -182,12 +182,13 @@
LibcMemoryBenchmarkMain.h
LibcMemoryBenchmarkMain.cpp
)
- target_link_libraries(${libc_target} PUBLIC json)
+
+ get_target_property(entrypoint_object_file ${entrypoint_target} "OBJECT_FILE_RAW")
+ target_link_libraries(${libc_target} PUBLIC json ${entrypoint_object_file})
foreach(configuration "small" "big")
add_libc_benchmark_configuration(${libc_target} ${configuration})
endforeach()
endfunction()
-add_libc_benchmark(memcpy Memcpy.cpp)
-add_libc_benchmark(memcmp Memcmp.cpp)
-add_libc_benchmark(memset Memset.cpp)
+add_libc_benchmark(memcpy Memcpy.cpp libc.src.string.memcpy)
+add_libc_benchmark(memset Memset.cpp libc.src.string.memset)
diff --git a/utils/benchmarks/JSON.cpp b/benchmarks/JSON.cpp
similarity index 100%
rename from utils/benchmarks/JSON.cpp
rename to benchmarks/JSON.cpp
diff --git a/utils/benchmarks/JSON.h b/benchmarks/JSON.h
similarity index 100%
rename from utils/benchmarks/JSON.h
rename to benchmarks/JSON.h
diff --git a/utils/benchmarks/JSONTest.cpp b/benchmarks/JSONTest.cpp
similarity index 100%
rename from utils/benchmarks/JSONTest.cpp
rename to benchmarks/JSONTest.cpp
diff --git a/utils/benchmarks/LibcBenchmark.cpp b/benchmarks/LibcBenchmark.cpp
similarity index 100%
rename from utils/benchmarks/LibcBenchmark.cpp
rename to benchmarks/LibcBenchmark.cpp
diff --git a/utils/benchmarks/LibcBenchmark.h b/benchmarks/LibcBenchmark.h
similarity index 100%
rename from utils/benchmarks/LibcBenchmark.h
rename to benchmarks/LibcBenchmark.h
diff --git a/utils/benchmarks/LibcBenchmarkTest.cpp b/benchmarks/LibcBenchmarkTest.cpp
similarity index 100%
rename from utils/benchmarks/LibcBenchmarkTest.cpp
rename to benchmarks/LibcBenchmarkTest.cpp
diff --git a/utils/benchmarks/LibcMemoryBenchmark.cpp b/benchmarks/LibcMemoryBenchmark.cpp
similarity index 100%
rename from utils/benchmarks/LibcMemoryBenchmark.cpp
rename to benchmarks/LibcMemoryBenchmark.cpp
diff --git a/utils/benchmarks/LibcMemoryBenchmark.h b/benchmarks/LibcMemoryBenchmark.h
similarity index 100%
rename from utils/benchmarks/LibcMemoryBenchmark.h
rename to benchmarks/LibcMemoryBenchmark.h
diff --git a/utils/benchmarks/LibcMemoryBenchmarkMain.cpp b/benchmarks/LibcMemoryBenchmarkMain.cpp
similarity index 100%
rename from utils/benchmarks/LibcMemoryBenchmarkMain.cpp
rename to benchmarks/LibcMemoryBenchmarkMain.cpp
diff --git a/utils/benchmarks/LibcMemoryBenchmarkMain.h b/benchmarks/LibcMemoryBenchmarkMain.h
similarity index 100%
rename from utils/benchmarks/LibcMemoryBenchmarkMain.h
rename to benchmarks/LibcMemoryBenchmarkMain.h
diff --git a/utils/benchmarks/LibcMemoryBenchmarkTest.cpp b/benchmarks/LibcMemoryBenchmarkTest.cpp
similarity index 100%
rename from utils/benchmarks/LibcMemoryBenchmarkTest.cpp
rename to benchmarks/LibcMemoryBenchmarkTest.cpp
diff --git a/utils/benchmarks/Memcmp.cpp b/benchmarks/Memcmp.cpp
similarity index 100%
rename from utils/benchmarks/Memcmp.cpp
rename to benchmarks/Memcmp.cpp
diff --git a/utils/benchmarks/Memcpy.cpp b/benchmarks/Memcpy.cpp
similarity index 94%
rename from utils/benchmarks/Memcpy.cpp
rename to benchmarks/Memcpy.cpp
index ef031d3..eb30853 100644
--- a/utils/benchmarks/Memcpy.cpp
+++ b/benchmarks/Memcpy.cpp
@@ -13,6 +13,10 @@
#include "llvm/Support/raw_ostream.h"
#include <memory>
+namespace __llvm_libc {
+extern void *memcpy(void *__restrict, const void *__restrict, size_t);
+} // namespace __llvm_libc
+
namespace llvm {
namespace libc_benchmarks {
diff --git a/utils/benchmarks/Memset.cpp b/benchmarks/Memset.cpp
similarity index 89%
rename from utils/benchmarks/Memset.cpp
rename to benchmarks/Memset.cpp
index f891b7b..e93b057 100644
--- a/utils/benchmarks/Memset.cpp
+++ b/benchmarks/Memset.cpp
@@ -12,6 +12,10 @@
#include "llvm/ADT/StringSwitch.h"
#include "llvm/Support/raw_ostream.h"
+namespace __llvm_libc {
+void *memset(void *, int, size_t);
+} // namespace __llvm_libc
+
namespace llvm {
namespace libc_benchmarks {
@@ -41,8 +45,8 @@
BenchmarkResult benchmark(const BenchmarkOptions &Options,
StringRef FunctionName, size_t Size) override {
- FunctionPrototype Function =
- StringSwitch<FunctionPrototype>(FunctionName).Case("memset", &::memset);
+ FunctionPrototype Function = StringSwitch<FunctionPrototype>(FunctionName)
+ .Case("memset", &__llvm_libc::memset);
return llvm::libc_benchmarks::benchmark(
Options, PP, [this, Function, Size](ParameterType p) {
Function(DstBuffer + p.DstOffset, MemsetValue, Size);
diff --git a/utils/benchmarks/RATIONALE.md b/benchmarks/RATIONALE.md
similarity index 100%
rename from utils/benchmarks/RATIONALE.md
rename to benchmarks/RATIONALE.md
diff --git a/utils/benchmarks/README.md b/benchmarks/README.md
similarity index 100%
rename from utils/benchmarks/README.md
rename to benchmarks/README.md
diff --git a/utils/benchmarks/configuration_big.json b/benchmarks/configuration_big.json
similarity index 100%
rename from utils/benchmarks/configuration_big.json
rename to benchmarks/configuration_big.json
diff --git a/utils/benchmarks/configuration_small.json b/benchmarks/configuration_small.json
similarity index 100%
rename from utils/benchmarks/configuration_small.json
rename to benchmarks/configuration_small.json
diff --git a/utils/benchmarks/render.py3 b/benchmarks/render.py3
similarity index 100%
rename from utils/benchmarks/render.py3
rename to benchmarks/render.py3
diff --git a/utils/CMakeLists.txt b/utils/CMakeLists.txt
index 8a7ee53..c6e877f 100644
--- a/utils/CMakeLists.txt
+++ b/utils/CMakeLists.txt
@@ -4,4 +4,3 @@
add_subdirectory(MPFRWrapper)
add_subdirectory(testutils)
add_subdirectory(UnitTest)
-add_subdirectory(benchmarks)
