tree e00a7d7315f4552bb306069198b1e2f4bef4a996
parent f6267a256d4f8461546a71825acfcd18c7fd443c
author Jeremy Morse <jeremy.morse@sony.com> 1582636333 +0000
committer Copybara-Service <copybara-worker@google.com> 1598820729 -0700

[debuginfo-tests] Warn, not error, if we can't delete working directory

On Windows, an error running the debugger typically leaves a process
hanging around in the working directory. When Dexter exits, it can't then
delete the working directory and produces an exception, masking the problem
in the debugger. (This can be worked around by specifying --save-temps).
Rather than hard-erroring, print a warning when we can't delete the working
directory instead.

It'd be much better to improve our error handling, and make the
WorkingDirectory class aware that something's wrong when it enters exit.
However, this is something that's going to mask genuine errors and make
everyones lives harder right now, so I think this non-ideal fix is
important to get in first.

Differential Revision: https://reviews.llvm.org/D74548

GitOrigin-RevId: 0a3b0837915e9796ae4279fe704efa663b89d815