commit 03664e8edaecb47ab4a7aba5c45283e0d3ca45cb
author gbMattN <matthew.nagy@sony.com> Wed May 28 14:51:50 2025 +0100
committer Copybara-Service <copybara-worker@google.com> Wed May 28 06:55:53 2025 -0700
tree cc65b2f36239a940916248efe19049413deea67f
parent aa6b7584b5f61f3bc7f1b66f7e05f0c5b3da5a02

Fixed small memory leak in libprofile (#141739)

Inside `getCurFilename`, there is this code snippit
```
if (!lprofCurFilename.FilenamePat || !lprofCurFilename.FilenamePat[0])
    return 0;
```
If this is true, we return `"\0"`, but would leak the memory in
`FilenameBuf`.
This pull request adds a free before then to properly free the memory.
There was already a check that we allocated memory, so there is no need
to worry about freeing unallocated memory.

GitOrigin-RevId: 2b1ebef8b8a5af7092de80daafd2743683d0e8c8

lib/profile/InstrProfilingFile.c

diff --git a/lib/profile/InstrProfilingFile.c b/lib/profile/InstrProfilingFile.c
index e6bab95..354f21b 100644
--- a/lib/profile/InstrProfilingFile.c
+++ b/lib/profile/InstrProfilingFile.c
@@ -1088,8 +1088,10 @@
     return "\0";
   }
   Filename = getCurFilename(FilenameBuf, 1);
-  if (!Filename)
+  if (!Filename) {
+    free(FilenameBuf);
     return "\0";
+  }
 
   return FilenameBuf;
 }