commit 3a248cf441974eb7a22645666218ff8e491f838b
author Abhina Sreeskantharajan <Abhina.Sreeskantharajan@ibm.com> Thu Mar 25 09:47:25 2021 -0400
committer Copybara-Service <copybara-worker@google.com> Thu Mar 25 13:20:53 2021 -0700
tree c493b65a084725029c2bd7f3b0d1c92b5ff28811
parent fe3c9cd8b130196e5e452d2250008f6d9bb60536

[NFC] Reordering parameters in getFile and getFileOrSTDIN

In future patches I will be setting the IsText parameter frequently so I will refactor the args to be in the following order. I have removed the FileSize parameter because it is never used.

```
  static ErrorOr<std::unique_ptr<MemoryBuffer>>
  getFile(const Twine &Filename, bool IsText = false,
          bool RequiresNullTerminator = true, bool IsVolatile = false);

  static ErrorOr<std::unique_ptr<MemoryBuffer>>
  getFileOrSTDIN(const Twine &Filename, bool IsText = false,
                 bool RequiresNullTerminator = true);

 static ErrorOr<std::unique_ptr<MB>>
 getFileAux(const Twine &Filename, uint64_t MapSize, uint64_t Offset,
            bool IsText, bool RequiresNullTerminator, bool IsVolatile);

  static ErrorOr<std::unique_ptr<WritableMemoryBuffer>>
  getFile(const Twine &Filename, bool IsVolatile = false);
```

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D99182

GitOrigin-RevId: c83cd8feef7eb8319131d968bb8c94fdc8dbb6a6