commit c30771cad3fb4d9eb23170a6a877598ccc9e34f7
author Timm Baeder <tbaeder@redhat.com> Thu Sep 11 05:08:08 2025 +0200
committer Copybara-Service <copybara-worker@google.com> Wed Sep 10 20:11:45 2025 -0700
tree 0ecce6dda15d8ff1f2231291da8096f879057076
parent 01487600bb211f23e9c5bc11d5db8866b915b2e3

[clang][bytecode] Check strlen impl for primitive arrays (#157494)

Fixes #157428

GitOrigin-RevId: 004231aaebdcae1c735c354a9a754ec00e4523c9

lib/AST/ByteCode/InterpBuiltin.cpp

diff --git a/lib/AST/ByteCode/InterpBuiltin.cpp b/lib/AST/ByteCode/InterpBuiltin.cpp
index d418e0a..91deda9 100644
--- a/lib/AST/ByteCode/InterpBuiltin.cpp
+++ b/lib/AST/ByteCode/InterpBuiltin.cpp
@@ -300,6 +300,9 @@
   if (!CheckDummy(S, OpPC, StrPtr.block(), AK_Read))
     return false;
 
+  if (!StrPtr.getFieldDesc()->isPrimitiveArray())
+    return false;
+
   assert(StrPtr.getFieldDesc()->isPrimitiveArray());
   unsigned ElemSize = StrPtr.getFieldDesc()->getElemSize();
 

test/AST/ByteCode/builtins.c

diff --git a/test/AST/ByteCode/builtins.c b/test/AST/ByteCode/builtins.c
new file mode 100644
index 0000000..a51260c
--- /dev/null
+++ b/test/AST/ByteCode/builtins.c
@@ -0,0 +1,19 @@
+// RUN: %clang_cc1 -fexperimental-new-constant-interpreter %s -verify
+// RUN: %clang_cc1                                         %s -verify=ref
+
+// expected-no-diagnostics
+// ref-no-diagnostics
+
+extern __SIZE_TYPE__ strlen(const char *);
+
+struct str_t {
+  char s1[sizeof("a")];
+};
+static const struct str_t str1 = {"a"};
+#define str ((const char *)&str1)
+int structStrlen(void) {
+  if (strlen(str) == 1)
+    return 0;
+  return 1;
+}
+