commit b7640f83d6933c2811c10b633d876e8105c64c29
author Eric Christopher <echristo@gmail.com> Thu Nov 12 00:44:04 2015 +0000
committer Copybara-Service <copybara-worker@google.com> Fri Sep 18 23:30:44 2020 -0700
tree c59e70db2303473d2ae77f7eb6b0717cfa20a824
parent c8a97f6275b7507504ad643acf113ae28fa0c435

In preparation to use it in more places rename
checkBuiltinTargetFeatures to checkTargetFeatures and sink
the error handling into the function.

llvm-svn: 252832
GitOrigin-RevId: c7e79dbec8b392e588e6c3bf17d611656a1f682d

lib/CodeGen/CGBuiltin.cpp

diff --git a/lib/CodeGen/CGBuiltin.cpp b/lib/CodeGen/CGBuiltin.cpp
index f82302b..9e5a075 100644
--- a/lib/CodeGen/CGBuiltin.cpp
+++ b/lib/CodeGen/CGBuiltin.cpp
@@ -344,24 +344,24 @@
 }
 
 // Returns true if we have a valid set of target features.
-bool CodeGenFunction::checkBuiltinTargetFeatures(
-    const FunctionDecl *TargetDecl) {
+void CodeGenFunction::checkTargetFeatures(const CallExpr *E,
+                                          const FunctionDecl *TargetDecl) {
   // Early exit if this is an indirect call.
   if (!TargetDecl)
-    return true;
+    return;
 
   // Get the current enclosing function if it exists. If it doesn't
   // we can't check the target features anyhow.
   const FunctionDecl *FD = dyn_cast_or_null<FunctionDecl>(CurFuncDecl);
   if (!FD)
-    return true;
+    return;
 
   unsigned BuiltinID = TargetDecl->getBuiltinID();
   const char *FeatureList =
       CGM.getContext().BuiltinInfo.getRequiredFeatures(BuiltinID);
 
   if (!FeatureList || StringRef(FeatureList) == "")
-    return true;
+    return;
 
   llvm::StringMap<bool> FeatureMap;
   CGM.getFunctionFeatureMap(FeatureMap, FD);
@@ -370,7 +370,7 @@
   // true, otherwise return false.
   SmallVector<StringRef, 1> AttrFeatures;
   StringRef(FeatureList).split(AttrFeatures, ",");
-  return std::all_of(AttrFeatures.begin(), AttrFeatures.end(),
+  if (!std::all_of(AttrFeatures.begin(), AttrFeatures.end(),
                      [&](StringRef &Feature) {
                        SmallVector<StringRef, 1> OrFeatures;
                        Feature.split(OrFeatures, "|");
@@ -378,7 +378,10 @@
                                           [&](StringRef &Feature) {
                                             return FeatureMap[Feature];
                                           });
-                     });
+		   }))
+    CGM.getDiags().Report(E->getLocStart(), diag::err_builtin_needs_feature)
+        << TargetDecl->getDeclName()
+        << CGM.getContext().BuiltinInfo.getRequiredFeatures(BuiltinID);
 }
 
 RValue CodeGenFunction::EmitBuiltinExpr(const FunctionDecl *FD,
@@ -1969,10 +1972,7 @@
   // This is down here to avoid non-target specific builtins, however, if
   // generic builtins start to require generic target features then we
   // can move this up to the beginning of the function.
-  if (!checkBuiltinTargetFeatures(FD))
-    CGM.getDiags().Report(E->getLocStart(), diag::err_builtin_needs_feature)
-        << FD->getDeclName()
-        << CGM.getContext().BuiltinInfo.getRequiredFeatures(BuiltinID);
+  checkTargetFeatures(E, FD);
 
   // See if we have a target specific intrinsic.
   const char *Name = getContext().BuiltinInfo.getName(BuiltinID);

lib/CodeGen/CodeGenFunction.h

diff --git a/lib/CodeGen/CodeGenFunction.h b/lib/CodeGen/CodeGenFunction.h
index 1aab00e..d0f37e6 100644
--- a/lib/CodeGen/CodeGenFunction.h
+++ b/lib/CodeGen/CodeGenFunction.h
@@ -2638,9 +2638,7 @@
   RValue EmitCallExpr(const CallExpr *E,
                       ReturnValueSlot ReturnValue = ReturnValueSlot());
 
-  void getFunctionFeatureMap(llvm::StringMap<bool> &FeatureMap,
-                             const FunctionDecl *FD);
-  bool checkBuiltinTargetFeatures(const FunctionDecl *TargetDecl);
+  void checkTargetFeatures(const CallExpr *E, const FunctionDecl *TargetDecl);
 
   llvm::CallInst *EmitRuntimeCall(llvm::Value *callee,
                                   const Twine &name = "");