commit 422b3daac85ba839db32d1d3f72621c8cdb67281
author Timm Baeder <tbaeder@redhat.com> Thu Sep 11 13:29:44 2025 +0200
committer Copybara-Service <copybara-worker@google.com> Thu Sep 11 04:31:35 2025 -0700
tree ec91beb46753c0ea99032d57f419888e7d15edf1
parent f499cb0b9baaf96b3b538985b6ff59a3b791a06e

[clang][bytecode] Use bytecode interpreter in EvaluateAsLValue (#158038)

Set the EvalMode on InterpState and abort when initalizing a global
temporary, like the current interpreter does. The rest is just plumbing
in EvaluateAsLValue.

Fixes #157497

GitOrigin-RevId: 9b00a58cbd8485ebf57e66e1c35b8ce86285e8fa

lib/AST/ByteCode/Interp.h

diff --git a/lib/AST/ByteCode/Interp.h b/lib/AST/ByteCode/Interp.h
index 2e9df41..9a7bd03 100644
--- a/lib/AST/ByteCode/Interp.h
+++ b/lib/AST/ByteCode/Interp.h
@@ -1527,6 +1527,8 @@
 template <PrimType Name, class T = typename PrimConv<Name>::T>
 bool InitGlobalTemp(InterpState &S, CodePtr OpPC, uint32_t I,
                     const LifetimeExtendedTemporaryDecl *Temp) {
+  if (S.EvalMode == EvaluationMode::ConstantFold)
+    return false;
   assert(Temp);
 
   const Pointer &Ptr = S.P.getGlobal(I);
@@ -1544,6 +1546,8 @@
 /// 3) Initialized global with index \I with that
 inline bool InitGlobalTempComp(InterpState &S, CodePtr OpPC,
                                const LifetimeExtendedTemporaryDecl *Temp) {
+  if (S.EvalMode == EvaluationMode::ConstantFold)
+    return false;
   assert(Temp);
 
   const Pointer &Ptr = S.Stk.peek<Pointer>();

lib/AST/ByteCode/InterpState.cpp

diff --git a/lib/AST/ByteCode/InterpState.cpp b/lib/AST/ByteCode/InterpState.cpp
index 1ec4191..a95916c 100644
--- a/lib/AST/ByteCode/InterpState.cpp
+++ b/lib/AST/ByteCode/InterpState.cpp
@@ -25,6 +25,7 @@
   CheckingPotentialConstantExpression =
       Parent.CheckingPotentialConstantExpression;
   CheckingForUndefinedBehavior = Parent.CheckingForUndefinedBehavior;
+  EvalMode = Parent.EvalMode;
 }
 
 InterpState::InterpState(State &Parent, Program &P, InterpStack &Stk,
@@ -36,6 +37,7 @@
   CheckingPotentialConstantExpression =
       Parent.CheckingPotentialConstantExpression;
   CheckingForUndefinedBehavior = Parent.CheckingForUndefinedBehavior;
+  EvalMode = Parent.EvalMode;
 }
 
 bool InterpState::inConstantContext() const {

lib/AST/ExprConstant.cpp

diff --git a/lib/AST/ExprConstant.cpp b/lib/AST/ExprConstant.cpp
index e1bacd0..5145896 100644
--- a/lib/AST/ExprConstant.cpp
+++ b/lib/AST/ExprConstant.cpp
@@ -17611,6 +17611,18 @@
   Info.InConstantContext = InConstantContext;
   LValue LV;
   CheckedTemporaries CheckedTemps;
+
+  if (Info.EnableNewConstInterp) {
+    if (!Info.Ctx.getInterpContext().evaluate(Info, this, Result.Val,
+                                              ConstantExprKind::Normal))
+      return false;
+
+    LV.setFrom(Ctx, Result.Val);
+    return CheckLValueConstantExpression(
+        Info, getExprLoc(), Ctx.getLValueReferenceType(getType()), LV,
+        ConstantExprKind::Normal, CheckedTemps);
+  }
+
   if (!EvaluateLValue(this, LV, Info) || !Info.discardCleanups() ||
       Result.HasSideEffects ||
       !CheckLValueConstantExpression(Info, getExprLoc(),