tree 000dba8aa01aaf1d502e8e92d4eb71d2e32d0387
parent fdb6006aec100901011fe7c76fb41556102eb22b
author Serge Guelton <sguelton@redhat.com> 1616618704 -0400
committer Copybara-Service <copybara-worker@google.com> 1618719569 -0700

Normalize interaction with boolean attributes

Such attributes can either be unset, or set to "true" or "false" (as string).
throughout the codebase, this led to inelegant checks ranging from

        if (Fn->getFnAttribute("no-jump-tables").getValueAsString() == "true")

to

        if (Fn->hasAttribute("no-jump-tables") && Fn->getFnAttribute("no-jump-tables").getValueAsString() == "true")

Introduce a getValueAsBool that normalize the check, with the following
behavior:

no attributes or attribute set to "false" => return false
attribute set to "true" => return true

Differential Revision: https://reviews.llvm.org/D99299

GitOrigin-RevId: d6de1e1a71406c75a4ea4d5a2fe84289f07ea3a1