tree f8589e0c88302c0a0e2e19d47478018563e4ea6e
parent 2b64ecab36177a14622db331313dfd696857ebca
author Clement Courbet <courbet@google.com> 1637336552 +0100
committer Copybara-Service <copybara-worker@google.com> 1637738169 -0800

[clang-tidy] performance-unnecessary-copy-initialization: Fix false negative.

`isConstRefReturningMethodCall` should be considering
`CXXOperatorCallExpr` in addition to `CXXMemberCallExpr`. Clang considers
these to be distinct (`CXXOperatorCallExpr` derives from `CallExpr`, not
`CXXMemberCallExpr`), but we don't care in the context of this
check.

This is important because of
`std::vector<Expensive>::operator[](size_t) const`.

Differential Revision: https://reviews.llvm.org/D114249

GitOrigin-RevId: ba4411e7c6a5879ce8acf246b0cd03ec738d9d6b