tree 5959a1f53b4aed596c610b17f72e14cae8c5a3a3
parent efa8be34fc74b12f843ae6dd18f143ef7f239f2d
author Edwin Vane <revane@google.com> 1715108811 -0400
committer Copybara-Service <copybara-worker@google.com> 1715109204 -0700

[clang-tidy] Refactor how NamedDecl are renamed (#88735)

The handling of renaming failures and multiple usages related to those
failures is currently spread over several functions. Identifying the
failure NamedDecl for a given usage is also duplicated, once when
creating failures and again when identify usages. There are currently
two ways to a failed NamedDecl from a usage: use the canonical decl or
use the overridden method. With new methods about to be added, a cleanup
was in order.

The data flow is simplified as follows:
* The visitor always forwards NamedDecls to addUsage(NamedDecl).
* addUsage(NamedDecl) determines the failed NamedDecl and determines
potential new names based on that failure. Usages are registered using
addUsage(NamingCheckId).
* addUsage(NamingCheckId) is now protected and its single responsibility
is maintaining the integrity of the failure/usage map.

GitOrigin-RevId: b1bc1dbea6d0423813bb73d625c6eedc040007ed