commit d2e4f3f2c4e32bc4f192271537c0eaa2c133b696
author jofrn <jofernau@amd.com> Mon Sep 08 10:15:20 2025 -0400
committer jofrn <jofernau@amd.com> Mon Sep 08 10:15:20 2025 -0400
tree 819bf8d3b365abb645fac9a784154fb4b9ac4736
parent ccd35e5b2f1438646d11c27eaa475f34681f9cbe

[Verifier][AMDGPU] The chain calling convention is invalid in particular situations like being on an architecture it cannot compile to.

llvm/lib/IR/Verifier.cpp

diff --git a/llvm/lib/IR/Verifier.cpp b/llvm/lib/IR/Verifier.cpp
index 1d3c379..63ae083 100644
--- a/llvm/lib/IR/Verifier.cpp
+++ b/llvm/lib/IR/Verifier.cpp
@@ -2938,10 +2938,16 @@
           "Calling convention parameter requires byval", &F);
     break;
   }
-  case CallingConv::AMDGPU_KERNEL:
-  case CallingConv::SPIR_KERNEL:
   case CallingConv::AMDGPU_CS_Chain:
   case CallingConv::AMDGPU_CS_ChainPreserve:
+  {
+    auto TT = M.getTargetTriple().str();
+    if (TT.find("gfx1200") || TT.find("gfx942"))
+      Check(false, "Chain calling convention is invalid on this target", &F);
+  }
+    [[fallthrough]];
+  case CallingConv::AMDGPU_KERNEL:
+  case CallingConv::SPIR_KERNEL:
     Check(F.getReturnType()->isVoidTy(),
           "Calling convention requires void return type", &F);
     [[fallthrough]];

llvm/test/CodeGen/AMDGPU/amdgpu-cs-chain-invalid-arch.ll

diff --git a/llvm/test/CodeGen/AMDGPU/amdgpu-cs-chain-invalid-arch.ll b/llvm/test/CodeGen/AMDGPU/amdgpu-cs-chain-invalid-arch.ll
new file mode 100644
index 0000000..c6f8a09
--- /dev/null
+++ b/llvm/test/CodeGen/AMDGPU/amdgpu-cs-chain-invalid-arch.ll
@@ -0,0 +1,6 @@
+; RUN: not llc -mtriple=amdgcn -mcpu=gfx1200 -o - < %s 2>&1 | FileCheck %s
+
+define amdgpu_cs_chain void @test_alloca() {
+; CHECK: Chain calling convention is invalid on this target
+  ret void
+}