commit fcd066412624a80ef2bacbe83c5aef99240083e2
author Kazu Hirata <kazu@google.com> Sun Apr 27 14:09:16 2025 -0700
committer GitHub <noreply@github.com> Sun Apr 27 14:09:16 2025 -0700
tree c674ce7cd346184dc59fb25ffef89aea12ab9531
parent ebbe970c86c99eeee5e480346847dbe6bcb1c95e

[AMDGPU] Simplify GetMember...::Get (NFC) (#137536)

We can use "constexpr if" to combine the two variants of functions.

llvm/lib/Target/AMDGPU/Utils/AMDKernelCodeTUtils.cpp

diff --git a/llvm/lib/Target/AMDGPU/Utils/AMDKernelCodeTUtils.cpp b/llvm/lib/Target/AMDGPU/Utils/AMDKernelCodeTUtils.cpp
index 8997911..0f4edd0 100644
--- a/llvm/lib/Target/AMDGPU/Utils/AMDKernelCodeTUtils.cpp
+++ b/llvm/lib/Target/AMDGPU/Utils/AMDKernelCodeTUtils.cpp
@@ -72,17 +72,11 @@
   class GetMember##member {                                                    \
   public:                                                                      \
     static const MCExpr *Phony;                                                \
-    template <typename U, typename std::enable_if_t<IsMCExpr##member::RESULT,  \
-                                                    U> * = nullptr>            \
-    static const MCExpr *&Get(U &C) {                                          \
-      assert(IsMCExpr##member::RESULT &&                                       \
-             "Trying to retrieve member that does not exist.");                \
-      return C.member;                                                         \
-    }                                                                          \
-    template <typename U, typename std::enable_if_t<!IsMCExpr##member::RESULT, \
-                                                    U> * = nullptr>            \
-    static const MCExpr *&Get(U &C) {                                          \
-      return Phony;                                                            \
+    template <typename U> static const MCExpr *&Get(U &C) {                    \
+      if constexpr (IsMCExpr##member::RESULT)                                  \
+        return C.member;                                                       \
+      else                                                                     \
+        return Phony;                                                          \
     }                                                                          \
   };                                                                           \
   const MCExpr *GetMember##member::Phony = nullptr;