tree 2e420b2b1c03d81569bfacca5676f4bb0205b015
parent 92e1be489a9a7a25857060872d6910573dfd41d5
author Emilio Cota <ecg@google.com> 1761299716 +0100
committer GitHub <noreply@github.com> 1761299716 +0100
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJo+00ECRC1aQ7uu5UhlAAAZJYQAH/Fm6jYRZZYxSmPWlDqdgpw
 hGk9MhTmOAjxxf5Ieh0LzHCpMWc5LHRFHfutEAsF5kGBHezYsxKvW/H9cmEA7mH1
 NlScBP1/oD0PIRligTlNPDvUdOQdlxljEvDSBK7okPBGbXFzuRYBa4QrSbPxF63T
 B0VAVlsCtfV5t461bV6mN481Nw+YZM/4a3AQ7BAoXlPOaWCsvB7kvqD74gNB6DEp
 Q1VcxPwm5isFcVFsDN/kdUtDmSJBav5axk2buJU99696ze1r7GA2crsD1idYP1r+
 y5F8qbN9dYTnd1Izwb+MnQgNTgRxqxPaTWtnOWINYvB/8scyMzw9Qr6kOCyat5+4
 o+fZIYHZoO888rMon4fe8AaCmA0LPkiZ8Hvt+FWMzqNZtBw0NdeZlTtg2T7O2wzM
 XfNylsfSfl8yYjRzTWJC2/948t+FIBGuKW/wWTH+pm/yyo6/Bty3xgd7oXIDSG65
 gtMCRdu3ijp+AgLAGS7Hq2JthMXn2pJL2HH7HKXzZ6frxc9rvclvxk2RVxKljxB0
 MojirBDljMBDymj40w73GF+YMQvOU8kkjbswkqtjUUc/S4kLzmvE93Ss0QQ6Sug3
 abDD8sJatESPaetbovGmw8iJrNQIDcXnSTnlfkkx13dI3DEOMm01PstqUmwjptiv
 Cr8b7uH1G0oAs1SidDcm
 =acTg
 -----END PGP SIGNATURE-----
 

[flang][mlir] fix irreflexibility violation of strict weak ordering in #155348 (#164833)

This fixes strict weak ordering checks violations from #155348 when
running these two tests:

    mlir/test/Dialect/OpenMP/omp-offload-privatization-prepare.mlir
    mlir/test/Dialect/OpenMP/omp-offload-privatization-prepare-by-value.mlir

Sample error:

    /stable/src/libcxx/include/__debug_utils/strict_weak_ordering_check.h:50: libc++ Hardening assertion !__comp(*__first + __a), *(__first + __b)) failed: Your comparator is not a valid strict-weak ordering

This is because (x < x) should be false, not true, to meet the
irreflexibility property. (Note that .dominates(x, x) returns true.)

I'm afraid that even after this commit we can't guarantee a strict weak
ordering, because we can't guarantee transitivity of equivalence by
sorting with a strict dominance function. However the tests are not
failing anymore, and I am not at all familiar with this code so I will
leave this concern up to the original author for consideration. (Ideas
without any further context: I would consider a topological sort or
walking a dominator tree.)

Reference on std::sort and strict weak ordering:

  https://danlark.org/2022/04/20/changing-stdsort-at-googles-scale-and-beyond/