tree d8501df522c2afbe7c28a92e4d658660c7af3d47
parent ddad7c3c84a8706ad539f1a69660a31a00b411a2
author Med Ismail Bennani <ismail@bennani.ma> 1715287912 -0700
committer GitHub <noreply@github.com> 1715287912 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJmPTdoCRC1aQ7uu5UhlAAAbJkQAIGOCTpvPzkBtI2c3zzZ4ZBm
 T+Mz1qy7BQr6qYz1cQkWa9afLjh8odWGAbeCXEaZ/yPllSzLOD2mEOyCNdx/oXWO
 brbghqSlsDYfyqf8eceTS6A1YNKznmWYq51wXBChmqpTMi0e4UtuBtipVBn+W58Z
 4ma1TjvgvyCqszQiwLrLmUGDKVRkPNTMH6cvwIu6AKJNp3VgATlRWj0GqsI0k9L2
 aBc9b33OjnlxT5VAjbPeFeZ1ULkznJDwQ4w+Bu/ijQddQwo9ATLHzSF08HP1aSM/
 CLG59CmURBG14cjwPu7IKjFGYRkpq+Z6ZCijtuMtblYCKTyloSXFHDuTtldEg18R
 bwv99uWHHFHJS7tc845EIWjKDD9c5ynn1cQxMXEU3P5X8V5jvYNzVNKfYZYjHZ+U
 5TKPCUcet5RkJLjMd59o6xz3LtV5i4bh5lbdp/g2G2K45yBu8dwse1iQ5s8KSwha
 Au2KxrIERhTtD53b/lSctttjkC57haJe9hvdNb/hHLUniLd3qKKyHN29c1+LoxN6
 X9G5TtjBOT+I/cVYj/07j9Wwjc7uoo/aUxq0oMVvCLBuLKkz33imWYpdPpZoGhHR
 JxM6UWKng4OKEjAtaA5H0gIMNuF/bBajC8fl3jrHwErztb2NGMr1R3eySE3Up04B
 Ir0NdoHO+Ym/PWjoqddV
 =vaiT
 -----END PGP SIGNATURE-----
 

[lldb/crashlog] Fix module binary resolution (#91631)

This patch fixes a bug in when resolving and loading modules from the
binary image list.

When loading a module, we would first use the UUID from the binary image
list with `dsymForUUID` to fetch the dSYM bundle from our remote build
records and copy the executable locally.

If we failed to find a matching dSYM bundle for that UUID on the build
record, let's say if that module was built locally, we use Spotlight
(`mdfind`) to find the dSYM bundle once again using the UUID.

Prior to this patch, we would set the image path to be the same as the
symbol file. This resulted in trying to load the dSYM as a module in
lldb, which isn't allowed.

This patch address that by looking for a binary matching the image
identifier, next to the dSYM bundle and try to load that instead.

rdar://127433616

Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>