[libcxx] Remove VLA from libcxx locale header The buffer size (`__nbuf`) in `num_put::do_put` is currently not an integral/core constant expression. As a result, `__nar` is a Variable Length Array (VLA). VLAs are a GNU extension and not part of the base C++ standard, so unless there is good reason to do so they probably shouldn't be used in any of the standard library headers. The call to `__iob.flags()` is the only thing keeping `__nbuf` from being a compile time constant, so the solution here is to simply err on the side of caution and always allocate a buffer large enough to fit the base prefix. Note that, while the base prefix for hex (`0x`) is slightly longer than the base prefix for octal (`0`), this isn't a concern. The difference in the space needed for the value portion of the string is enough to make up for this. (Unless we're working with small, oddly sized types such as a hypothetical `uint9_t`, the space needed for the value portion in octal is at least 1 more than the space needed for the value portion in hex). This PR also adds `constexpr` to `__nbuf` to enforce compile time const-ness going forward. Reviewed By: Mordante, #libc, Quuxplusone, ldionne Differential Revision: https://reviews.llvm.org/D103558
This directory and its sub-directories contain source code for LLVM, a toolkit for the construction of highly optimized compilers, optimizers, and run-time environments.
The README briefly describes how to get started with building LLVM. For more information on how to contribute to the LLVM project, please take a look at the Contributing to LLVM guide.
Taken from https://llvm.org/docs/GettingStarted.html.
Welcome to the LLVM project!
The LLVM project has multiple components. The core of the project is itself called “LLVM”. This contains all of the tools, libraries, and header files needed to process intermediate representations and convert them into object files. Tools include an assembler, disassembler, bitcode analyzer, and bitcode optimizer. It also contains basic regression tests.
C-like languages use the Clang front end. This component compiles C, C++, Objective-C, and Objective-C++ code into LLVM bitcode -- and from there into object files, using LLVM.
Other components include: the libc++ C++ standard library, the LLD linker, and more.
The LLVM Getting Started documentation may be out of date. The Clang Getting Started page might have more accurate information.
This is an example work-flow and configuration to get and build the LLVM source:
Checkout LLVM (including related sub-projects like Clang):
git clone https://github.com/llvm/llvm-project.git
Or, on windows, git clone --config core.autocrlf=false https://github.com/llvm/llvm-project.git
Configure and build LLVM and Clang:
cd llvm-project
cmake -S llvm -B build -G <generator> [options]
Some common build system generators are:
Ninja --- for generating Ninja build files. Most llvm developers use Ninja.Unix Makefiles --- for generating make-compatible parallel makefiles.Visual Studio --- for generating Visual Studio projects and solutions.Xcode --- for generating Xcode projects.Some Common options:
-DLLVM_ENABLE_PROJECTS='...' --- semicolon-separated list of the LLVM sub-projects you'd like to additionally build. Can include any of: clang, clang-tools-extra, libcxx, libcxxabi, libunwind, lldb, compiler-rt, lld, polly, or debuginfo-tests.
For example, to build LLVM, Clang, libcxx, and libcxxabi, use -DLLVM_ENABLE_PROJECTS="clang;libcxx;libcxxabi".
-DCMAKE_INSTALL_PREFIX=directory --- Specify for directory the full path name of where you want the LLVM tools and libraries to be installed (default /usr/local).
-DCMAKE_BUILD_TYPE=type --- Valid options for type are Debug, Release, RelWithDebInfo, and MinSizeRel. Default is Debug.
-DLLVM_ENABLE_ASSERTIONS=On --- Compile with assertion checks enabled (default is Yes for Debug builds, No for all other build types).
cmake --build build [-- [options] <target>] or your build system specified above directly.
The default target (i.e. ninja or make) will build all of LLVM.
The check-all target (i.e. ninja check-all) will run the regression tests to ensure everything is in working order.
CMake will generate targets for each tool and library, and most LLVM sub-projects generate their own check-<project> target.
Running a serial build will be slow. To improve speed, try running a parallel build. That's done by default in Ninja; for make, use the option -j NNN, where NNN is the number of parallel jobs, e.g. the number of CPUs you have.
For more information see CMake
Consult the Getting Started with LLVM page for detailed information on configuring and compiling LLVM. You can visit Directory Layout to learn about the layout of the source code tree.