[analyzer][NFC] Remove leftover PreElideState stash in copy elision (#211518) computeObjectUnderConstruction stashed the program state into PreElideState "before trying to elide, as it'll get overwritten", but never used it. That comment and stash are fossils of the old prepareForObjectConstruction, which returned and threaded the state (`std::tie(State, V) = ...`); the failure path then reverted it with `State = PreElideState;`. The refactor to the SVal-returning computeObjectUnderConstruction (State is now passed by value and the state updates moved to updateObjectsUnderConstruction) dropped that revert but left the stash and comment behind. State is never overwritten here anymore, so remove the dead PreElideState and reword the comment to describe only the CallOpts stash, which is still needed (CallOpts is passed by reference and genuinely overwritten by the elision attempt). Found with a clang-query matcher over clang/lib/StaticAnalyzer. Assisted-by: claude
Welcome to the LLVM project!
This repository contains the source code for LLVM, a toolkit for the construction of highly optimized compilers, optimizers, and run-time environments.
The LLVM project has multiple components. The core of the project is itself called “LLVM”. This contains all of the tools, libraries, and header files needed to process intermediate representations and convert them into object files. Tools include an assembler, disassembler, bitcode analyzer, and bitcode optimizer.
C-like languages use the Clang frontend. This component compiles C, C++, Objective-C, and Objective-C++ code into LLVM bitcode -- and from there into object files, using LLVM.
Other components include: the libc++ C++ standard library, the LLD linker, and more.
Consult the Getting Started with LLVM page for information on building and running LLVM.
For information on how to contribute to the LLVM project, please take a look at the Contributing to LLVM guide.
Join the LLVM Discourse forums, Discord chat, LLVM Office Hours or Regular sync-ups.
The LLVM project has adopted a code of conduct for participants to all modes of communication within the project.