[SPIRV] Fix global emission for modules with no functions (#183833) Right now we have a problem where if you have a LLVM module with globals but no functions, a completely empty SPIR-V module is emitted. This is because global emission is dependent on tracking intrinsic functions being emitted in functions. As a simple fix, just insert a service function, which the backend is already set up to not actually emit, if there are no real functions. The current use case of the service function is for function pointers. I don't think it's possible that we need to both generate a service function for function pointers and for globals with no functions, so I just added an error (not an assert) just in case if we do need it for both cases. Probably we should rework global handling in the future to work without these workarounds, but this is a pretty fundamental issue so let's work around it with this simple change for now. This change exposed an existing bug: We consider basic blocks with no successors as fall-through Also, fix some existing tests. The symptom was: We previously emitted an empty module, but not that we don't, we hit a `spirv-val` error about invalid Function StorageClass for globals because no `addrspace` was specified. Set the `addrspace` to `1` (`CrossWorkgroup`) in those tests. Closes: https://github.com/llvm/llvm-project/issues/182899 --------- Signed-off-by: Nick Sarnie <nick.sarnie@intel.com>
Welcome to the LLVM project!
This repository contains the source code for LLVM, a toolkit for the construction of highly optimized compilers, optimizers, and run-time environments.
The LLVM project has multiple components. The core of the project is itself called “LLVM”. This contains all of the tools, libraries, and header files needed to process intermediate representations and convert them into object files. Tools include an assembler, disassembler, bitcode analyzer, and bitcode optimizer.
C-like languages use the Clang frontend. This component compiles C, C++, Objective-C, and Objective-C++ code into LLVM bitcode -- and from there into object files, using LLVM.
Other components include: the libc++ C++ standard library, the LLD linker, and more.
Consult the Getting Started with LLVM page for information on building and running LLVM.
For information on how to contribute to the LLVM project, please take a look at the Contributing to LLVM guide.
Join the LLVM Discourse forums, Discord chat, LLVM Office Hours or Regular sync-ups.
The LLVM project has adopted a code of conduct for participants to all modes of communication within the project.