| commit | d7390be0646821d58d104f164c693ce7f1f970cb | [log] [tgz] |
|---|---|---|
| author | Carlos Galvez <carlosgalvezp@gmail.com> | Sat Aug 23 21:41:05 2025 +0200 |
| committer | GitHub <noreply@github.com> | Sat Aug 23 21:41:05 2025 +0200 |
| tree | ec525d3c337bcdf445759b4eb877366e70ab352b | |
| parent | 3ca1ca4301703ceadd0ab9c0b156bd6c0a3af7ec [diff] |
[clang-tidy] Skip system macros in readability-identifier-naming check (#132016)
Currently, the check is processing system macros. Most importantly, it
tries to find .clang-tidy files associated with those files, if the
option GetConfigPerFile (on by default) is active.
This is problematic for a number of reasons:
- System macros cannot be acted upon (renamed), so it's wasted work.
- When the main .cpp file includes a system header, clang-tidy tries to
find the .clang-tidy file for that system header. When that system
header is a 3rd-party repository, they may have their own .clang-tidy
file, which may not be compatible with the current version of
clang-tidy. So, clang-tidy may fail to analyze our main.cpp file, only
because it includes a 3rd-party system header whose .clang-tidy file is
incompatible with our clang-tidy binary.
Therefore, skip system macros in this check.
This reduces the amount of unwanted warnings as follows:
On trunk:
Suppressed 11448 warnings (11448 in non-user code).
With this patch:
Suppressed 4824 warnings (4824 in non-user code).
The runtime is pretty much unchanged.
Co-authored-by: Carlos Gálvez <carlos.galvez@zenseact.com>
Welcome to the LLVM project!
This repository contains the source code for LLVM, a toolkit for the construction of highly optimized compilers, optimizers, and run-time environments.
The LLVM project has multiple components. The core of the project is itself called “LLVM”. This contains all of the tools, libraries, and header files needed to process intermediate representations and convert them into object files. Tools include an assembler, disassembler, bitcode analyzer, and bitcode optimizer.
C-like languages use the Clang frontend. This component compiles C, C++, Objective-C, and Objective-C++ code into LLVM bitcode -- and from there into object files, using LLVM.
Other components include: the libc++ C++ standard library, the LLD linker, and more.
Consult the Getting Started with LLVM page for information on building and running LLVM.
For information on how to contribute to the LLVM project, please take a look at the Contributing to LLVM guide.
Join the LLVM Discourse forums, Discord chat, LLVM Office Hours or Regular sync-ups.
The LLVM project has adopted a code of conduct for participants to all modes of communication within the project.