[CIR] Use SymbolTableCollection in LoweringPrepare's getCalledFunction (#195919)

`LoweringPreparePass::lowerTrivialCopyCall` calls `getCalledFunction`
once per `cir.call`, which used the static
`mlir::SymbolTable::lookupNearestSymbolFrom` — that function does a
linear scan of every operation in the module on each call, giving O(N ×
M) total for N calls in an M-operation module.

The pass already maintains a `SymbolTableCollection` (used by
`lowerStoreOfConstAggregate` and `lowerLocalInitOp`). Thread it through
`getCalledFunction` and `lowerTrivialCopyCall` so the per-call lookup
uses the cached hash-based path instead.

Measured on Eigen's `bdcsvd.cpp` (heavy template instantiation): the
15.06% self-time hotspot from `getCalledFunction` is eliminated,
contributing roughly another 2x compile-time speedup on the slowest
tests.

The cold path in `getOrCreateDtorFunc` (per-global, not per-call) is
left on the static lookup with an explanatory comment to avoid threading
`symbolTables` through `emitGlobalGuardedDtorRegion` and its callers.

Companion to #195883 (`applyReplacements`) and #195916
(`CIRToLLVMCallOpLowering`) — same algorithmic anti-pattern in three
different passes.

Made with [Cursor](https://cursor.com)

Co-authored-by: Cursor <cursoragent@cursor.com>
1 file changed
tree: 44782f1e25b7dc794abf45da4f95bdbbae855267
  1. .ci/
  2. .github/
  3. bolt/
  4. clang/
  5. clang-tools-extra/
  6. cmake/
  7. compiler-rt/
  8. cross-project-tests/
  9. flang/
  10. flang-rt/
  11. libc/
  12. libclc/
  13. libcxx/
  14. libcxxabi/
  15. libsycl/
  16. libunwind/
  17. lld/
  18. lldb/
  19. llvm/
  20. llvm-libgcc/
  21. mlir/
  22. offload/
  23. openmp/
  24. orc-rt/
  25. polly/
  26. runtimes/
  27. third-party/
  28. utils/
  29. .clang-format
  30. .clang-format-ignore
  31. .clang-tidy
  32. .git-blame-ignore-revs
  33. .gitattributes
  34. .gitignore
  35. .mailmap
  36. CODE_OF_CONDUCT.md
  37. CONTRIBUTING.md
  38. LICENSE.TXT
  39. pyproject.toml
  40. README.md
  41. SECURITY.md
README.md

The LLVM Compiler Infrastructure

OpenSSF Scorecard OpenSSF Best Practices libc++

Welcome to the LLVM project!

This repository contains the source code for LLVM, a toolkit for the construction of highly optimized compilers, optimizers, and run-time environments.

The LLVM project has multiple components. The core of the project is itself called “LLVM”. This contains all of the tools, libraries, and header files needed to process intermediate representations and convert them into object files. Tools include an assembler, disassembler, bitcode analyzer, and bitcode optimizer.

C-like languages use the Clang frontend. This component compiles C, C++, Objective-C, and Objective-C++ code into LLVM bitcode -- and from there into object files, using LLVM.

Other components include: the libc++ C++ standard library, the LLD linker, and more.

Getting the Source Code and Building LLVM

Consult the Getting Started with LLVM page for information on building and running LLVM.

For information on how to contribute to the LLVM project, please take a look at the Contributing to LLVM guide.

Getting in touch

Join the LLVM Discourse forums, Discord chat, LLVM Office Hours or Regular sync-ups.

The LLVM project has adopted a code of conduct for participants to all modes of communication within the project.