tree a12dc3351fad673c0c38c047efd9b3627629c1ae
parent ee6913cc8317c08b603daed64b07a17a95ec926a
author Matheus Izvekov <mizvekov@gmail.com> 1631663190 +0200
committer Tom Stellard <tstellar@redhat.com> 1632500290 -0700

[clang] don't mark as Elidable CXXConstruct expressions used in NRVO

See PR51862.

The consumers of the Elidable flag in CXXConstructExpr assume that
an elidable construction just goes through a single copy/move construction,
so that the source object is immediately passed as an argument and is the same
type as the parameter itself.

With the implementation of P2266 and after some adjustments to the
implementation of P1825, we started (correctly, as per standard)
allowing more cases where the copy initialization goes through
user defined conversions.

With this patch we stop using this flag in NRVO contexts, to preserve code
that relies on that assumption.
This causes no known functional changes, we just stop firing some asserts
in a cople of included test cases.

Reviewed By: rsmith

Differential Revision: https://reviews.llvm.org/D109800

(cherry picked from commit d9308aa39b236064a680ca57178af3c731e13e49)