[lldb][Formatters] Remove broken/redundant lookup into anonymous child when extracting from compressed pairs (#175564) (brought to my attention in https://github.com/llvm/llvm-project/pull/155153#discussion_r2682666325) This patch removes the `anon_struct_idx` of `GetValueOrOldCompressedPair`. The latest `_LIBCPP_COMPRESSED_PAIR` wraps the members in an anonymous structure. Around the time of the original patch that introduced `GetValueOrOldCompressedPair` (https://github.com/llvm/llvm-project/pull/155153), `GetChildMemberWithName` wasn't capable of "seeing through" anonymous structures when searching for children. However, around the same time as https://github.com/llvm/llvm-project/pull/155153 landed, the `GetChildMemberWithName` behaviour was fixed (in https://github.com/llvm/llvm-project/pull/138487). So regardless of whether the the compressed pair is wrapped in an anonymous structure, simply calling `GetChildMemberWithName` is the right thing to do. We weren't even using the result of `GetChildAtIndex`, so we were always calling `GetChildMemberWithName` with the root ValueObject anyways. Our `libcxx-simulators` already test both compressed pair layouts, so no extra coverage is needed here.
Welcome to the LLVM project!
This repository contains the source code for LLVM, a toolkit for the construction of highly optimized compilers, optimizers, and run-time environments.
The LLVM project has multiple components. The core of the project is itself called “LLVM”. This contains all of the tools, libraries, and header files needed to process intermediate representations and convert them into object files. Tools include an assembler, disassembler, bitcode analyzer, and bitcode optimizer.
C-like languages use the Clang frontend. This component compiles C, C++, Objective-C, and Objective-C++ code into LLVM bitcode -- and from there into object files, using LLVM.
Other components include: the libc++ C++ standard library, the LLD linker, and more.
Consult the Getting Started with LLVM page for information on building and running LLVM.
For information on how to contribute to the LLVM project, please take a look at the Contributing to LLVM guide.
Join the LLVM Discourse forums, Discord chat, LLVM Office Hours or Regular sync-ups.
The LLVM project has adopted a code of conduct for participants to all modes of communication within the project.